Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use localized format for idle-screen/gui #110

Merged
merged 5 commits into from
Mar 29, 2021

Conversation

domcross
Copy link
Contributor

Description

GUI/idle-screen shows weekday name and date in localized format.

Type of PR

  • Bugfix
  • Feature implementation
  • Refactor of code (without functional changes)
  • Documentation improvements
  • Test improvements

CLA

  • CLA signed

Copy link
Contributor

@krisgesling krisgesling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Dom, thanks for this. Definitely a good change to make.

I haven't tested it across languages but it's working for English and I'm sure you tested it for German.

I had a few suggestions and questions:

__init__.py Outdated Show resolved Hide resolved
__init__.py Outdated Show resolved Hide resolved
__init__.py Outdated Show resolved Hide resolved
__init__.py Outdated Show resolved Hide resolved
__init__.py Outdated Show resolved Hide resolved
@krisgesling
Copy link
Contributor

Thanks for doing the updates.

I made a tiny addition to ensure the month is always capitalized also.

@krisgesling krisgesling merged commit ab6af5a into MycroftAI:20.08 Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants